On Fri, 14 Feb 2025 01:40:59 GMT, Alexey Semenyuk <asemen...@openjdk.org> wrote:

>> Convert jpackage test library tests in JUnit format. This simplifies running 
>> them in IDE.
>> 
>> Added 
>> [JUnitAdapter](https://github.com/openjdk/jdk/pull/23615/files#diff-8719943fb769c04daf413427dc812650763f588cbd0ef6b50cccd11260353c0a)
>>  class to simplify running jpackage test-lib tests with JUnit. 
>> `JUnitAdapter.runJPackageTests()` will run the jpackage test-lib test as a 
>> JUnit test. The test work directory will be created in a temporary directory 
>> supplied by JUnit.
>> 
>> All jpackage test-lib test classes changed to extend `JUnitAdapter`. As they 
>> didn't have a default ctor, they were converted accordingly.
>> 
>> Important: Set `test.src` system property if run these tests outside of 
>> jtreg (from IDE) or ad-hoc replace `@@openJdkDir@@` token with the path to 
>> local OpenJDK repo at 
>> [JUnitAdapter.java:46](https://github.com/openjdk/jdk/pull/23615/files#diff-8719943fb769c04daf413427dc812650763f588cbd0ef6b50cccd11260353c0a).
>
> Alexey Semenyuk has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   Remove redundant "return"

Marked as reviewed by almatvee (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/23615#pullrequestreview-2616582376

Reply via email to