On Fri, 14 Feb 2025 19:55:05 GMT, Naoto Sato <[email protected]> wrote:
>> Joe Wang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> un-needed property removed
>
> test/jaxp/javax/xml/jaxp/unittest/transform/JDK8207760.java line 112:
>
>> 110: public final void testBug8349699() throws Exception {
>> 111: String xs = "x".repeat(1017);
>> 112: String expected = xs +
>> "\uD835\uDF03\uD835\uDF00\uD835\uDF00\uD835\uDF00\uD835\uDF00";
>
> Would it be meaningful if we provided invalid sequences e.g, high/high and or
> low/low at the boundary to see if the logic successfully detects them?
Thanks Naoto. Added test cases with invalid sequences (high/high, low/low).
Also added test cases to verify both edge and normal cases.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23623#discussion_r1960764599
