On Wed, 19 Feb 2025 06:50:33 GMT, Jaikiran Pai <j...@openjdk.org> wrote:
> This part however feels odd. Updating this (and other tests in future) to use > the `@requires !jdk.static` to identify the presence or absence of a specific > tool in the JDK installation doesn't seem right. Perhaps they should instead > rely on a tool-specific property (like maybe `@requires jdk.tool.jlink`)? The property will be useful to select the tests that can or cannot be selected by jtreg when the JDK under test is static image. Three are a number of tests that depend on layout or specific files in the modular run-time image so they will need to skipped when the JDK is a static image. So nothing to do with whether specific tools are present or not. The specific test updated here is a bit strange because lib/modules should never be a sym link in the first place and motivation for that is probably a different discussion. ------------- PR Comment: https://git.openjdk.org/jdk/pull/23528#issuecomment-2667741172
