On Wed, 19 Feb 2025 02:54:36 GMT, Chen Liang <li...@openjdk.org> wrote:
>> I don't know if we have a style guide that covers this, but I believe the >> method and field could both be named `isPrimitive`. > > I would personally name such a boolean field `primitive`, but I don't have a > strong preference on the field naming as long as its references in tests and > other locations are correct. In addition, I believe this field may soon be > widened to carry more hotspot-specific flags (such as hidden, etc.) so the > name is bound to change. I like 'primitive'. 'hidden' is also a possibility to add to this and give it the same treatment. I didn't do that one here to limit the changes and I haven't seen all the calls to isHidden so would need to find out how to measure the effects of that change. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/23572#discussion_r1961722833
