On Mon, 24 Feb 2025 11:58:11 GMT, David Beaumont <d...@openjdk.org> wrote:
>> 8349206: j.u.l.Handler classes create deadlock risk via synchronized >> publish() method. >> >> 1. Remove synchronization of calls to publish() in Handlers in >> java.util.logging package. >> 2. Add explanatory comments to various affected methods. >> 3. Add a test to ensure deadlocks no longer occur. >> >> Note that this change does not address issue in MemoryHandler (see >> JDK-8349208). > > David Beaumont has updated the pull request incrementally with one additional > commit since the last revision: > > Adding @implNote to new JavaDoc. src/java.logging/share/classes/java/util/logging/Handler.java line 47: > 45: * > 46: * <h2>Subclass Implementation Notes</h2> > 47: * Have you looked at how this is rendered in the generated API documentation when loaded up in the browser? I mean `@implNote` is usually a section on its own, so I am unsure whether lines 46-47 above should be moved inside the `@implNote` section or simply removed. Or maybe it's OK to leave them there - but I am afraid it would appear as an empty subsection in the normative API documentation. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/23491#discussion_r1967540935
