On Wed, 26 Feb 2025 17:18:16 GMT, Jorn Vernee <jver...@openjdk.org> wrote:
>> Chen Liang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Review remarks, dates, some more simplifications > > src/java.base/share/classes/java/lang/invoke/X-VarHandleSegmentView.java.template > line 83: > >> 81: bb.unsafeGetBase(), >> 82: offset(bb, base, offset), >> 83: handle.be); > > Why do we not have a call to `convEndian` here? This is just how it was. Refer to line 141 in old diff. > src/java.base/share/classes/jdk/internal/foreign/Utils.java line 74: > >> 72: return ret; >> 73: return computeFilterHandle(index); >> 74: } > > Why is this using an array, instead of just having 3 fields? This emulates how MethodHandleImpl does the cache. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/23720#discussion_r1972306931 PR Review Comment: https://git.openjdk.org/jdk/pull/23720#discussion_r1972312952
