On Mon, 24 Feb 2025 16:21:33 GMT, He-Pin(kerr) <d...@openjdk.org> wrote:
>> Motivation:
>> When a user passes a wrong parameter, the current implementation throws an
>> IllegalArgumentException with an error message `null`, which is not helpful.
>>
>> Modification:
>> Add detail error messages.
>>
>> Result:
>> Helpful messages.
>
> He-Pin(kerr) has updated the pull request incrementally with one additional
> commit since the last revision:
>
> chore: update tests
test/jdk/java/util/concurrent/tck/ThreadPoolExecutorTest.java line 746:
> 744: shouldThrow();
> 745: } catch (IllegalArgumentException success) {
> 746: Assert.assertEquals("corePoolSize must be non-negative, but
> got -1", success.getMessage());
I think just checking `corePoolSize` is contained in the error message is fine.
Also printing the exact corePoolSize value might be unsafe.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23050#discussion_r1974340646
