On Thu, 27 Feb 2025 17:15:56 GMT, David Beaumont <d...@openjdk.org> wrote:
>> 8349206: j.u.l.Handler classes create deadlock risk via synchronized >> publish() method. >> >> 1. Remove synchronization of calls to publish() in Handlers in >> java.util.logging package. >> 2. Add explanatory comments to various affected methods. >> 3. Add a test to ensure deadlocks no longer occur. >> >> Note that this change does not address issue in MemoryHandler (see >> JDK-8349208). > > David Beaumont has updated the pull request incrementally with one additional > commit since the last revision: > > Fix @implNote to @apiNote. OK I think this is getting close. Only two small issues remain from my point of view: 1. small updates to `@implSpec` in StreamHandler.publish() 2. small update to be a bit more specific in the comment above StreamHandler.flushAndClose(). Unfortunately they require the CSR to be updated again. ------------- PR Comment: https://git.openjdk.org/jdk/pull/23491#issuecomment-2689476844
