On Thu, 27 Feb 2025 19:52:13 GMT, Justin Lu <j...@openjdk.org> wrote:
>> Please review this PR which clarifies some behavior regarding NumberFormat >> grouping specifically in the grouping related methods. >> >> Please see the corresponding CSR for further detail. Note that an >> alternative would be to specify this at the DecimalFormat level, allowing >> NumberFormat subclasses to define this behavior how they want. IMO, I would >> expect `setGroupingUsed(boolean)` to affect both; a subclass could define >> `(is|set)(Parsing|Formatting)GroupingUsed` if need be, thus the proposed >> solution. > > Justin Lu has updated the pull request incrementally with one additional > commit since the last revision: > > make strict example less wordy LGTM ------------- Marked as reviewed by naoto (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/23813#pullrequestreview-2651436794
