On Mon, 3 Mar 2025 13:33:05 GMT, Sean Mullan <mul...@openjdk.org> wrote:
> Please review this fix to a test that fails when run with --enable-preview. > This fix is to add all the necessary utility classes imported by the test to > the JAR file, and not just the test classes. The description in the JBS issue wasn't clear why this test would fail in this manner with `--enable-preview`. I looked at this a bit and I've added a comment to that JBS issue explaining what the issue is about. I believe the proposed change here to package the necessary class files in the JAR file, so that they are available when launching `java` with that JAR file in the classpath, is correct. ------------- Marked as reviewed by jpai (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/23864#pullrequestreview-2656806335
