On Fri, 14 Mar 2025 15:49:44 GMT, Magnus Ihse Bursie <i...@openjdk.org> wrote:
> We should allow pre-built JVMs to be included in a build, so they are just > copied into place, and the jvm.cfg file properly updated. make/modules/java.base/Copy.gmk line 128: > 126: $(foreach import_jvm, $(IMPORT_JVM_NAMES), \ > 127: $(eval $(import_jvm)_path := $(patsubst $(import_jvm):%,%,$(filter > $(import_jvm):%, $(IMPORT_JVMS)))) \ > 128: $(eval $(call MakeDir, $(LIB_DST_DIR)/$(import_jvm))) \ Do you really need to call MakeDir outside of a recipe? Won't SetupCopyFiles recipes create this directory? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/24063#discussion_r2000996873
