On Tue, 18 Mar 2025 13:09:10 GMT, Erik Joelsson <er...@openjdk.org> wrote:
> If we want to support CDS archives for the imported JVMs, then we would need > to modify the loop in Images.gmk so that it covers them as well. I think that > makes sense to do. Yes, I agree. That, and importing the whole directory, is the two changes I have on my mental todo list for this PR. > make/modules/java.base/Copy.gmk line 128: > >> 126: $(foreach import_jvm, $(IMPORT_JVM_NAMES), \ >> 127: $(eval $(import_jvm)_path := $(patsubst $(import_jvm):%,%,$(filter >> $(import_jvm):%, $(IMPORT_JVMS)))) \ >> 128: $(eval $(call MakeDir, $(LIB_DST_DIR)/$(import_jvm))) \ > > Do you really need to call MakeDir outside of a recipe? Won't SetupCopyFiles > recipes create this directory? I assumed it would, but it failed, and I looked at the code and found no clear evidence that it does, so I added this. It might have been some other issue, so I can double-check again, if you are certain that SetupCopyFiles should create needed directories. ------------- PR Comment: https://git.openjdk.org/jdk/pull/24063#issuecomment-2733171467 PR Review Comment: https://git.openjdk.org/jdk/pull/24063#discussion_r2001014378
