On Fri, 14 Mar 2025 18:35:22 GMT, Joe Wang <jo...@openjdk.org> wrote:
>> Add public identifiers to the JDK built-in Catalog; Replace the incorrect
>> Schema 1.1 DTD files (note the Public Identifier at line 2) with the correct
>> Shema 1.0 DTDs.
>
> Joe Wang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> update the test: change variables and etc.
test/jaxp/javax/xml/jaxp/unittest/common/jdkcatalog/JDKCatalogTest.java line 25:
> 23: package common.jdkcatalog;
> 24:
> 25: import static jaxp.library.JAXPTestUtilities.SRC_DIR;
Static imports across classes (even with a package) make it harder to read the
test and know where it is imported from. The reference in the source here
should include the class its imported from.
test/jaxp/javax/xml/jaxp/unittest/common/jdkcatalog/JDKCatalogTest.java line
143:
> 141: public void testDTDsInJDKCatalog(String publicId, String systemId) {
> 142: String matchingPubId = JDKCATALOG.matchPublic(publicId);
> 143: String matchingSysId = JDKCATALOG.matchSystem(systemId);
Isn't there a public API to get these values. It seems a bit of a hack to have
to break module encapsulation.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24039#discussion_r2001787672
PR Review Comment: https://git.openjdk.org/jdk/pull/24039#discussion_r2001803674
