On Mon, 24 Mar 2025 14:35:50 GMT, Alexey Semenyuk <asemen...@openjdk.org> wrote:
> Follow-up for https://github.com/openjdk/jdk/pull/24087 PR. > Revamp signing tests: > - Run the tests only if `jpackage.test.MacSignTests` property is set to > "run". This property also can be set to "setup" and "teardown" to set up and > tear down jpackage signing test environment. See > https://github.com/openjdk/jdk/pull/24087 PR. > - Moved tests from SigningOptionsTest.java to ErrorTest.java. Altered > `JPackageCommand.validateOutput()` to safely handle the case of an empty list > of expected strings. > - Removed SigningCheck.java. Verification of jpackage signing test > environment is performed in `SigningBase.verifySignTestEnvReady()` method > using verification API from MacSign class. > `SigningBase.verifySignTestEnvReady()` method is called in every signing > jtreg test. It is a replacement for `SigningCheck.checkCertificates()` call. > - Change signatures of test methods to leverage capabilities of jpackage > test lib added in https://github.com/openjdk/jdk/pull/21996 PR. > > Before these changes, if the signing test environment was not set, signing > tests exited with "skipped" status. With this change, these tests will not be > executed unless `jpackage.test.MacSignTests` property is set to "run". The > tests fail if the property is set and the signing test environment is not set > correctly. This is a deliberate choice to encourage running these tests only > if the signing test environment is configured correctly. This pull request has now been integrated. Changeset: b2da0d34 Author: Alexey Semenyuk <asemen...@openjdk.org> URL: https://git.openjdk.org/jdk/commit/b2da0d341b740eb5fbb784075adb3433427c3cff Stats: 357 lines in 10 files changed: 59 ins; 284 del; 14 mod 8352289: [macos] Review skipped tests in tools/jpackage/macosx/SigningPackage* Reviewed-by: almatvee ------------- PR: https://git.openjdk.org/jdk/pull/24201
