On Tue, 8 Apr 2025 15:02:27 GMT, Feilong Jiang <[email protected]> wrote:
>> Hamlin Li has updated the pull request with a new target base due to a merge
>> or a rebase. The incremental webrev excludes the unrelated changes brought
>> in by the merge/rebase. The pull request contains five additional commits
>> since the last revision:
>>
>> - typo
>> - Merge branch 'master' into cmoveil-v1
>> - turn off flag Zicond by default
>> - remove
>> - initial commit
>
> src/hotspot/cpu/riscv/riscv.ad line 9979:
>
>> 9977:
>> 9978: format %{
>> 9979: "CMove $dst, ($op1 $cop $op2), $dst, $src\t#@cmovI_cmpF\n\t"
>
> Should be `CMoveI` too?
Yes, fixed. Thanks
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24490#discussion_r2034842102
