On Wed, 9 Apr 2025 12:36:21 GMT, Chen Liang <li...@openjdk.org> wrote:
>> One of the features of the LinkedBlockingDeque is that it is a doubly-linked >> node queue, with pointers in each node to "prev" and "next", which allows >> remove() in the Iterator to remove the node in constant time. However, in >> the JavaDoc of the class, it lists Iterator.remove() as an example of a >> method that takes linear time. > > Thanks! FYI the CSR requires a few more fields to be filled - see > https://wiki.openjdk.org/display/csr/Fields+of+a+CSR+Request for details. You > can click the "Edit" button on the CSR to see all those fields; many are not > available in the browsing view. > > In addition, I think you can mention that this constant time is already the > preexisting behavior and indicate there is no (minimal, "None" means the > field is not filled) compatibility risk. > > Once you have filled all required or needed fields (In particular, don't > forget about fix version of 25 and scope of SE), I can review the CSR and you > can proceed to move it to "Finalized" (Click on the "Draft" button) > @liach JCheck configuration is invalid in the target branch of this pull > request. Please issue this command again once the problem has been resolved. Any idea what this is about @liach ? ------------- PR Comment: https://git.openjdk.org/jdk/pull/24500#issuecomment-2789559918