On Tue, 15 Apr 2025 06:38:15 GMT, Chen Liang <li...@openjdk.org> wrote:
>> Alan Bateman has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 15 commits: >> >> - Add JEP number, update copyright headers >> - Merge branch 'master' into JDK-8342486 >> - Sync up from loom repo >> - Merge branch 'master' into JDK-8342486 >> - Sync up from loom repo >> - Merge branch 'master' into JDK-8342486 >> - Merge branch 'master' into JDK-8342486 >> - Fix link >> - Merge branch 'master' into JDK-8342486 >> - Sync up impl/tests form loom repo >> - ... and 5 more: https://git.openjdk.org/jdk/compare/3090e218...418bc3d3 > > src/java.base/share/classes/java/util/concurrent/Joiners.java line 190: > >> 188: * A joiner that returns a stream of all subtasks. >> 189: */ >> 190: static class AllSubtasks<T> implements Joiner<T, >> Stream<Subtask<T>>> { > > Suggestion: > > static final class AllSubtasks<T> implements Joiner<T, > Stream<Subtask<T>>> { All the others are (non-public) static final, this one was missed, thanks! ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/21934#discussion_r2046135304