On Thu, 17 Apr 2025 03:37:03 GMT, Hao Sun <hao...@openjdk.org> wrote:

> I was wondering if `--disable-java-warnings-as-errors` could help to address 
> your concern about this PR.

It doesn't address the issue unless it's configured by default, which I don't 
think is being proposed. I think the best approach would be to disable 
`-Werror` for specific compilations that are using `sun.misc` APIs, instead of 
disabling it for the entire build using `--disable-java-warnings-as-errors`. 
You can also proceed with this as-is and revisit if JDK-8349846 happens, I 
think it's up to you and the reviewers.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/23686#issuecomment-2811699055

Reply via email to