On Thu, 17 Apr 2025 22:13:06 GMT, Brian Burkhalter <b...@openjdk.org> wrote:
>> Implement the requested methods and add a test thereof. > > Brian Burkhalter has updated the pull request incrementally with one > additional commit since the last revision: > > 8354724: Change the test to reuse a ByteBuffer when writing the file There's a case to be made to have readString() on Reader instead of BufferedReader. The somewhat analogous method readAllBytes() is on InputStream. The bulk transferTo() method appears on both InputStream and Reader. From a practical standpoint, there are a lot of APIs in the JDK that return a Reader (not a BufferedReader) so having readString() on Reader saves the caller an extra step of wrapping it in a BufferedReader or creating a StringWriter as the destination of transferTo(). ------------- PR Comment: https://git.openjdk.org/jdk/pull/24728#issuecomment-2814135868
