On Thu, 17 Apr 2025 22:05:31 GMT, Naoto Sato <[email protected]> wrote:
>> Justin Lu has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> simple/special case in check invocation
>
> test/jdk/java/util/Currency/ValidateISO4217.java line 203:
>
>> 201: CodeTransform codeTransform = (codeBuilder, e) -> {
>> 202: switch (e) {
>> 203: case InvokeInstruction i when
>> i.name().stringValue().equals("currentTimeMillis") ->
>
> `equalsString()` may be used. Regardless, is there a way to tell this call is
> indeed `System.currentTimeMillis()`? Might do that check in case a method on
> Currency with the same name is introduced (not likely though).
Yes, we can check the owner name is _java/lang/System_. Addressed your other
comment as well in
https://github.com/openjdk/jdk/pull/24701/commits/c58f11f2affa19267aa2416bcff10f842c13d871.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24701#discussion_r2049739614
