On Mon, 21 Apr 2025 22:36:08 GMT, Alexander Matveev <almat...@openjdk.org>
wrote:
>> Alexey Semenyuk has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix compilation error
>
> test/jdk/tools/jpackage/helpers/jdk/jpackage/test/MacSign.java line 410:
>
>> 408: continue;
>> 409: }
>> 410: certs.add(cert);
>
> Maybe:
>
> try {
> final X509Certificate cert =
> (X509Certificate)CERT_FACTORY.generateCertificate(in);
> certs.add(cert);
> } catch (Exception ex) {
> TKit.trace("Failed to parse certificate data: " +
> ex);
> }
This will combine certificate creation and adding it to the list of
certificates. If the latter fails, this is not a `Failed to parse certificate
data` error.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24762#discussion_r2053129886
