On Wed, 19 Mar 2025 20:07:26 GMT, Roger Riggs <rri...@openjdk.org> wrote:
>> The current test program for the logging feature added in JDK-8301627 does >> not fully check some important cases. >> >> Issue Details: >> The test does not properly check cases where logging might not happen due to >> different logging levels. (e.g. ALL, TRACE, WARNING, etc.) >> The check for the logged stack trace is not enough, as it does not confirm >> enough details in the output. >> >> Fix Details: >> Added more test cases to check behavior under different logging levels. >> Improved the stack trace check by verifying more details in the logged >> output. >> These changes make the test more complete and ensure that the logging >> feature works as expected. >> Also, any existing test cases prior to this pull request are retained. >> >> The test was verified in the following OS environments, and it passed >> successfully in both environments. >> - Windows Server 2022 Standard 21H2 >> - Red Hat Enterprise Linux release 9.2 (Plow) >> >> Could you please review this fix? > > Out of curiosity, what raised this as an issue that needed more tests? > Was there a failure of some implementation that caused a bug? Hi, @RogerRiggs I have answered some of your comments. Could you please take another look? ------------- PR Comment: https://git.openjdk.org/jdk/pull/24050#issuecomment-2823243699
