On Wed, 23 Apr 2025 01:34:42 GMT, Naoto Sato <[email protected]> wrote:
>> Stuart Marks has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update sun.stdout/err.encoding comments; tweak Windows file handle
>> variable name.
>
> src/java.base/windows/native/libjava/java_props_md.c line 637:
>
>> 635:
>> 636: {
>> 637: HANDLE hStdIn;
>
> Instead of creating a new variable, `hStdOutErr` could be reused with a
> proper name.
OK I merged the local variables into a single one named `hStdHandle`. I'm not
sure that's the best name. I surmise that the `h` prefix is "Hungarian
Notation" to indicate that it's a handle, though it makes the name kind of
redundant.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24738#discussion_r2056539283
