On Fri, 25 Apr 2025 07:57:53 GMT, Eirik Bjørsnøs <eir...@openjdk.org> wrote:
> @liach suggested to remove the wrapper classes and instead use a static > method with `instanceof` checking. That would remove the need for both the > interface and the wrapper classes which seems like a real improvement. > @AlanBateman seems to have been reluctant to such a change, but I don't think > I (or others in this PR) quite understood his reasoning for that opposition. I commented on the iteration that introduced printStackTrace0(Object printer) as it was just begging to be replaced again. Johannes Döbler's suggestion avoids that. There are probably 100 others ways it could be written. As others have noted, the motivation for the JBS issue and PR isn't very clear. There are many large features and changes in progress right now, I think better for potential Reviewers to focus on helping those rather than on churn code in core classes. ------------- PR Comment: https://git.openjdk.org/jdk/pull/24795#issuecomment-2829716111
