On Thu, 24 Apr 2025 20:46:42 GMT, Brian Burkhalter <b...@openjdk.org> wrote:
> Use the `@requires` tag instead of obtaining the operating system name from > the `os.name` property and then exiting if the test is not run on that > operating system. a general comment on this approach of running tests selectively on an OS via @requires It is all cool and dandy, but this has implications on the visibility of the test not being run. It will be added to the jtreg "not run" list When running test locally that's fine, this is easily seen in the jtreg report, but when run in the test frameworks CI pipeline, this "not run " visibility is obscured. Thus when doing test run audit of a jobs, requires a bit more effort to locate test that have not been run. An alternative practice has been to throw a SkippedException and this is more easily observed in a pipeline job's results, as the SkippedException are part of all results, and jtreg now reports Skipped tests in its summary ------------- PR Comment: https://git.openjdk.org/jdk/pull/24860#issuecomment-2830009985
