On Wed, 23 Apr 2025 00:21:05 GMT, Chen Liang <li...@openjdk.org> wrote:
>> The ClassFile API promotes usage of constant nominal descriptors over >> literal strings. However, for `class` file parsing, currently the efficient >> way to check if a constant pool entry matches a desired descriptor is via >> unrolling them back to strings. However, string unrolling is ugly, and often >> times confusing, such as internal names versus field descriptors. >> >> As a result, I propose to provide new methods that compare constant pool >> entries with the potential symbolic descriptors they represent. This is no >> less efficient as checking raw string equality, avoids exceptional failure >> behaviors of conversion to symbolic descriptors, and avoids potential >> programmer errors stemming from raw string handling. See the CSR for a full >> story. > > Chen Liang has updated the pull request with a new target base due to a merge > or a rebase. The incremental webrev excludes the unrelated changes brought in > by the merge/rebase. The pull request contains three additional commits since > the last revision: > > - Rename UTF8 test methods to be different from other test methods > - Merge branch 'master' of https://github.com/openjdk/jdk into > feature/cf-equals-sym > - 8342206: Convenience method to check if a constant pool entry matches > nominal descriptors Thanks for the review. I have updated the tests to move the actually tested contents to the human-readable parameterized tests; unfortunately the process of spawning pool entries is very complicated and I have to keep it in the huge block in the bottom of the file. ------------- PR Comment: https://git.openjdk.org/jdk/pull/23548#issuecomment-2830885288
