On Sat, 26 Apr 2025 09:18:35 GMT, Kim Barrett <kbarr...@openjdk.org> wrote:
>> The newly-added `WhiteBox.waitForReferenceProcessing()` (see >> [8305186](https://bugs.openjdk.org/browse/JDK-8305186)) always fails with >> assertions enabled. >> I've updated the assertion, and also added the test I used locally to test >> the new method (just not with assertions enabled, apparently.) > > test/hotspot/jtreg/vmTestbase/gc/gctests/ReferencesGC/WaitForRefProTest.java > line 1: > >> 1: /* > > Wrong place for this test. vmTestbase is old tests, converted from an old > testing infrastructure. > See the readme here: > https://github.com/openjdk/jdk/tree/master/test/hotspot/jtreg/vmTestbase > In particular, at the bottom of that page: "New tests must *not* be added > into this directory." > > This new test belongs in `test/lib-test/jdk/test/whitebox/`. Also, s/Pro/Proc/ in the name of the test. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/24892#discussion_r2061240134
