On Fri, 25 Apr 2025 14:49:37 GMT, Aleksey Shipilev <sh...@openjdk.org> wrote:
> CDS cannot handle large number of classes, because `ClassLoader` data > structures get too large for CDS archival. The new test captures such an > occasion. We do `clear()`-s, but that is not enough to trim the backing > storages for the affected collections. > > In contrast with previous attempts to fix this > (https://github.com/openjdk/jdk/pull/21797 and my VM-side field overwrite), > we can just reinitialize the fields using `Unsafe`, which bypasses normal > `final` field write restriction. `ClassLoader` already does a similar thing > nearby! This allows us to stay fully in Java, and makes the patch fairly > straightforward. > > Additional testing: > - [x] Linux x86_64 server fastdebug, new test reliably fails without the > fix, passes with it > - [x] Linux x86_64 server fastdebug, `runtime/cds` test/hotspot/jtreg/runtime/cds/appcds/LotsOfSyntheticClasses.java line 67: > 65: out.add("}"); > 66: for (int c = 0; c < NUM_NESTED_CLASSES; c++) { > 67: out.add("public static class " + NESTED_CLASS_NAME + c + " > {}"); Suggestion: out.add("public static class " + NESTED_CLASS_NAME + c + " {}"); ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/24877#discussion_r2062715919
