On Fri, 25 Apr 2025 19:17:51 GMT, Dan Heidinga <heidi...@openjdk.org> wrote:
>> Ioi Lam has updated the pull request incrementally with one additional >> commit since the last revision: >> >> @fisk comment > > src/hotspot/share/cds/aotReferenceObjSupport.cpp line 76: > >> 74: // the use of Weak/Soft references used by java.lang.invoke. >> 75: // >> 76: // We intent to evolve the implementation in the future by > > Suggestion: > > // We intend to evolve the implementation in the future by Fixed. > src/java.base/share/classes/jdk/internal/misc/CDS.java line 93: > >> 91: >> 92: >> 93: private static ArrayList<Object> keepAliveList; > > Is it worth adding a comment stating this list should only be populated > during an assembly phase? That it should be null in both training and > production runs? I added comments and asserts for clarification. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/24757#discussion_r2062899404 PR Review Comment: https://git.openjdk.org/jdk/pull/24757#discussion_r2062899353
