On Mon, 28 Apr 2025 13:40:47 GMT, Jorn Vernee <jver...@openjdk.org> wrote:

>> Chen Liang has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   Simplify FFM linker warmup
>
> make/jdk/src/classes/build/tools/classlist/HelloClasslist.java line 184:
> 
>> 182:                 ADDRESS, ADDRESS, ADDRESS,
>> 183:                 JAVA_BOOLEAN, ADDRESS, ADDRESS);
>> 184:         Linker.nativeLinker().downcallHandle(signature);
> 
> Why do we care specifically about this shape, but not about others?

That was from the past attempt of linking Class forName0. Tge exact shape 
doesn't really matter here as we are mainly saving on DMH.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24742#discussion_r2063704198

Reply via email to