On Sun, 27 Apr 2025 03:38:35 GMT, Chen Liang <li...@openjdk.org> wrote:
>> Internal explicit counter support for Code max_stack and max_locals has been >> already added in #24807. Since that example works well, we may consider >> opening this functionality up to general users under strict restrictions. >> >> This is an advanced API; thus, I chose a more complex name >> `withExplicitStackAndLocals` that discourages accidental use, and indicates >> the exact order of stack and locals arguments. For integrity, the argument >> checks are unconditional. And this is also barred behind `DROP_STACK_MAPS` >> advanced option. >> >> I have enhanced the tests with a `CodeBuilderType` utility to test all types >> of code builders; it is already effective at increasing coverage in some of >> our existing tests that only cover DirectCodeBuilder, and simplify other >> tests. It is particularly helpful for my new `BuilderExplicitMaxsTest`. > > Chen Liang has updated the pull request incrementally with one additional > commit since the last revision: > > Adjust indents I think the original issue was created in response to a public request https://mail.openjdk.org/pipermail/classfile-api-dev/2024-August/000545.html. It just happens that we and another public audience both want this API, so I guess it is not too much of a "corner case"? ------------- PR Comment: https://git.openjdk.org/jdk/pull/24903#issuecomment-2835350966
