On Mon, 28 Apr 2025 16:45:01 GMT, Brian Burkhalter <b...@openjdk.org> wrote:

>> Use the `@requires` tag instead of obtaining the operating system name from 
>> the `os.name` property and then exiting if the test is not run on that 
>> operating system.
>
> Brian Burkhalter has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   8355444: Add comment tag tp ManyFiles

There are lots of tests using @requires to only run on relevant configurations.
If there needs to be more complete accounting of tests not run on each 
platform, it belongs as a feature in jtreg. 
Switching to use SkippedException in some tests but not having a clear and 
consistent distinction seems like just making things more complicated and 
harder to understand on a test by test basis.
The ship may have sailed here, but a more consistent pattern should be 
developed.

-------------

PR Review: https://git.openjdk.org/jdk/pull/24860#pullrequestreview-2800046182

Reply via email to