On Mon, 28 Apr 2025 20:04:22 GMT, Chen Liang <li...@openjdk.org> wrote:
>> Javadoc for java.util.Optional.orElseThrow(Supplier) misses mentioning of >> another possible cause of a NullPointerException - when the exception >> supplying function returns a null result. >> --------- >> ### Progress >> - [ ] Change must be properly reviewed (1 review required, with at least 1 >> [Reviewer](https://openjdk.org/bylaws#reviewer)) >> - [x] Change requires CSR request >> [JDK-8354953](https://bugs.openjdk.org/browse/JDK-8354953) to be approved >> - [x] Change must not contain extraneous whitespace >> - [x] Commit message must refer to an issue >> >> ### Error >> ⚠️ The pull request body must not be empty. >> >> >> >> ### Reviewing >> <details><summary>Using <code>git</code></summary> >> >> Checkout this PR locally: \ >> `$ git fetch https://git.openjdk.org/jdk.git pull/23905/head:pull/23905` \ >> `$ git checkout pull/23905` >> >> Update a local copy of the PR: \ >> `$ git checkout pull/23905` \ >> `$ git pull https://git.openjdk.org/jdk.git pull/23905/head` >> >> </details> >> <details><summary>Using Skara CLI tools</summary> >> >> Checkout this PR locally: \ >> `$ git pr checkout 23905` >> >> View PR using the GUI difftool: \ >> `$ git pr show -t 23905` >> >> </details> >> <details><summary>Using diff file</summary> >> >> Download this PR as a diff file: \ >> <a >> href="https://git.openjdk.org/jdk/pull/23905.diff";>https://git.openjdk.org/jdk/pull/23905.diff</a> >> >> </details> > > Also please add some of your own text to the pull request body, like the > first sentence of the issue report: > >> Javadoc for java.util.Optional.orElseThrow(Supplier) misses mentioning of >> another possible cause of a NullPointerException - when the exception >> supplying function returns a null result. > > Once you have pushed the changes, Chris or I may review this for integration. @liach @RogerRiggs Sorry, I forgot a part of the specification! Now we are ready! ------------- PR Comment: https://git.openjdk.org/jdk/pull/23905#issuecomment-2836857568
