On Tue, 29 Apr 2025 10:23:26 GMT, Maurizio Cimadamore <mcimadam...@openjdk.org> wrote:
>> Jan Lahoda has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 13 commits: >> >> - Merge branch 'master' into JDK-8344708 >> - Adjusting ToolProviderTest to the updated persistence handling. >> - Merge branch 'master' into JDK-8344708 >> - Reflecting review feedback: cleanup formatting in ModuleInfo. >> - Reflecting review feedback - avoiding hardcoded constants. >> - Fixing test. >> - Cleanup, fixing tests. >> - Adjusting JShell defaults. >> - Fixing tests. >> - Cleanup - updated specification will permit requires transitive >> java.base; for all classfile versions; java.se no longer participates in >> preview. >> - ... and 3 more: https://git.openjdk.org/jdk/compare/1f228e55...da39d0ef > > src/jdk.jshell/share/classes/jdk/jshell/SnippetMaps.java line 197: > >> 195: return full.substring(pkg.length() + 1); >> 196: } >> 197: Stream<String> mods = importSnippets() > > Should this variable be called `mods` ? AFAIU, it lists all the packages > exported by a module. Thanks, attempted to improve here: https://github.com/openjdk/jdk/pull/23801/commits/4f9575564c3761b251288c3dec0132cbe0a16139 ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/23801#discussion_r2066219542
