On Tue, 29 Apr 2025 13:37:06 GMT, Alexey Semenyuk <asemen...@openjdk.org> wrote:
>> - Add missing "post-image" infrastructure on Linux.
>> - Fix "post-image" infrastructure on macOS and Windows.
>> - Add relevant tests.
>> - Update TKit to support new tests.
>
> Alexey Semenyuk has refreshed the contents of this pull request, and previous
> commits have been removed. The incremental views will show differences
> compared to the previous content of the PR. The pull request contains 10 new
> commits since the last revision:
>
> - Fix modifiers order
> - Update
> src/jdk.jpackage/linux/classes/jdk/jpackage/internal/LinuxDebBundler.java
>
> Co-authored-by: Hendrik Schick <30866028+k...@users.noreply.github.com>
> - Better test coverage
> - Change signature of TKit.assertEquals(String, String, String) to
> TKit.assertEquals(Object, Object, String)
> - Add Comm.uniqueEmpty()
> - - Add TKit.assertDirectoryContentRecursive()
> - Fix log messages of TKit.assertDirectoryExists()
> - Reorder actions in PKG packaging to ensure user post-image script is
> invoked before any PKG is created.
> - Fix formatting
> - - Add missing "post-image" script execution to Linux bundlers
> - Add tests to verify the context of "post-image" script on all platforms
> - Set current directory for "post-image" script on Windows and macOS
> inside of the app image directory
> - 8355651: Premature execution of post-image hook
src/jdk.jpackage/linux/classes/jdk/jpackage/internal/LinuxDebBundler.java line
505:
> 503: .setScriptNameSuffix("post-image")
> 504: .setEnvironmentVariable("JpAppImageDir",
> thePackage.sourceRoot().toAbsolutePath().toString())
> 505: .run(params);
Suggestion:
.setDirectory(thePackage.sourceRoot())
.setResourceCategoryId("resource.post-app-image-script")
.setScriptNameSuffix("post-image")
.setEnvironmentVariable("JpAppImageDir",
thePackage.sourceRoot().toAbsolutePath().toString())
.run(params);
8 spaces
(?)
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24899#discussion_r2063078074
