On Tue, 29 Apr 2025 16:15:05 GMT, Gautham Krishnan <d...@openjdk.org> wrote:
>> MET timezone entry in TimeZoneNames.java and TimeZoneNames_*.java needs to >> be updated as MET is alias to Europe/Brussels as per 2024b tzdata changes. >> >> Also Bug4848242.java needs to be removed as the test expects all euro locale >> time zones should have the same short names. > > Gautham Krishnan has updated the pull request incrementally with one > additional commit since the last revision: > > Bringing back Bug4848242.java > > Reverting the change to delete Bug4848242.java as it is still worth > testing, with comments adjusted. Thanks for bringing back the test case. Please add the bug id [8342886](https://bugs.openjdk.org/browse/JDK-8342886) in the test header. test/jdk/sun/util/resources/TimeZone/Bug4848242.java line 31: > 29: * but due to changes in time zone data and locale handling, that > is no longer guaranteed. > 30: * This test now verifies that a representative sample of locales > (e.g., DE, FR, IT) > 31: * still use the same short names (CET/CEST). I think German is not in the samples here (it will not return "CET"/"CEST"). Also please use lowercase for the language, eg, fr/it, uppwercased letters are usually for regions. ------------- PR Review: https://git.openjdk.org/jdk/pull/24871#pullrequestreview-2804305540 PR Review Comment: https://git.openjdk.org/jdk/pull/24871#discussion_r2066932598
