On Wed, 30 Apr 2025 00:28:40 GMT, Zhengyu Gu <z...@openjdk.org> wrote:
>> Ioi Lam has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> @fisk comment -- use proper HeapAccess to load referent; Also refactor
>> AOTReferenceObjSupport::is_enabled()
>
> src/hotspot/share/cds/aotReferenceObjSupport.cpp line 122:
>
>> 120: ik->initialize(CHECK);
>> 121:
>> 122: TempNewSymbol field_name = SymbolTable::new_symbol("N""ULL");
>
> Why "N""ULL", not "NULL"?
That's because a stand-lone word "NULL" will cause
hotspot/jtreg/sources/TestNoNULL.java to fail. I have renamed the internal
field to NULL_QUEUE to avoid the failure, per recommendation of @kimbarrett
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24757#discussion_r2067691778
