On Tue, 29 Apr 2025 14:51:08 GMT, Jorn Vernee <jver...@openjdk.org> wrote:
>> Per Minborg has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Make public constuctor private
>
> test/jdk/java/lang/StableValue/StableFunctionTest.java line 79:
>
>> 77: void factoryInvariants(Set<Value> inputs) {
>> 78: assertThrows(NullPointerException.class, () ->
>> StableValue.function(null, MAPPER));
>> 79: assertThrows(NullPointerException.class, () ->
>> StableValue.function(inputs, null));
>
> I think you also need a case for `null` elements in `inputs`
There is a separate `@Test void nullKeys()` that takes care of that case.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23972#discussion_r2067935980
