On Wed, 30 Apr 2025 18:17:27 GMT, Chen Liang <li...@openjdk.org> wrote:
>> Take the class file version to reject flags not yet defined, redefined, or >> obsoleted. This is useful for clients like javap to report the correct >> undefined flags for different class file versions. >> >> A preparatory patch for javap to pass around the ClassFileFormatVersion to >> parse flags is available at #24955. > > Chen Liang has updated the pull request with a new target base due to a merge > or a rebase. The pull request now contains 27 commits: > > - review: improve comments about implicit null checks > - Merge branch 'fix/javap-cffv-access-flags' into feature/af-cffv-parse > - Merge branch 'feature/af-location-accessors' into feature/af-cffv-parse > - Explicit imports > - Wording updates > - Merge branch 'feature/af-location-accessors' into feature/af-cffv-parse > - Update specs for other existing APIs > - Wording updates, thanks Roger > - Missing since > - Fix javap causing strictfp tests to fail > - ... and 17 more: https://git.openjdk.org/jdk/compare/b3af1964...10be287f lgtm ------------- Marked as reviewed by rriggs (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/24760#pullrequestreview-2808132607
