On Thu, 1 May 2025 13:36:13 GMT, Roger Riggs <rri...@openjdk.org> wrote:
> Remove internal ValueBased annotation from the ProcessHandle interface
> declaration.
> The implementation remains value based as described in the javadoc.
> Remove unnecessary "public" keyword in interfaces and cleanup javadoc.
Good cleanup, now interfaces are no longer identity or value.
src/java.base/share/classes/java/lang/ProcessHandle.java line 287:
> 285: * {@link java.util.concurrent.Future#get() wait} for it to
> terminate.
> 286: * {@link java.util.concurrent.Future#cancel(boolean) Cancelling}
> 287: * the {@linkplain CompletableFuture CompletableFuture} does not
> affect the Process.
Suggestion:
* the {@linkplain CompletableFuture} does not affect the Process.
is sufficient.
-------------
Marked as reviewed by liach (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/24986#pullrequestreview-2809842025
PR Review Comment: https://git.openjdk.org/jdk/pull/24986#discussion_r2070303153
