On Thu, 27 Mar 2025 17:57:37 GMT, Hamlin Li <m...@openjdk.org> wrote:

>> Robbin Ehn has updated the pull request with a new target base due to a 
>> merge or a rebase. The incremental webrev excludes the unrelated changes 
>> brought in by the merge/rebase. The pull request contains four additional 
>> commits since the last revision:
>> 
>>  - Merge branch 'master' into qemu-user-issues
>>  - more
>>  - more
>>  - native or very long
>
> I also feel annoying to see some tests fail interminently.
> 
> Not sure if I understand the goal of this pr, seems it might not be the best 
> solution to simply disable these tests when running with qemu. My concerns 
> are: qemu is still one of main methods to quickly verify the functionality 
> changes, but when we just disable the failed tests, and maybe in the future 
> disable more and more tests, then qemu is no longer able to play the role it 
> was supposed to play.

Thanks @Hamlin-Li and @RealFYang.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/24229#issuecomment-2847064204

Reply via email to