On Wed, 30 Apr 2025 17:06:28 GMT, Brian Burkhalter <b...@openjdk.org> wrote:
>> Use the `@requires` tag instead of obtaining the operating system name from >> the `os.name` property and then exiting if the test is not run on that >> operating system. > > Brian Burkhalter has updated the pull request incrementally with one > additional commit since the last revision: > > 8355444: Remove requires tag from ManyFiles Hello Brian, I went back and checked the history of this ManyFiles test. The original test did not have the check to skip running on Linux. I do see which commit introduced that check but it doesn't have any additional details other than the brief code comment which said "Linux does not yet allow opening this many files". That was back in 2003. So I think the removal of this check and `@requires` is fine. > I ran 30 repeats on each of the two Linux architectures in the CI I would suggest doing a similar run without specifying a specific test platform. That way it will get run on all relevant platforms. I don't expect it to fail, but it would be good to have that tested before this is integrated. ------------- Marked as reviewed by jpai (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/24860#pullrequestreview-2811947219
