On Mon, 5 May 2025 21:44:36 GMT, Alexey Semenyuk <[email protected]> wrote:
> - Refactor PathGroup
> - Add test cases to PathGroupTest
> - Update UsrTreeTest to verify "libapplauncher.so" is placed in the correct
> location in the package
> - Refactor UsrTreeTest to use JPackageCommand assert functions
Looks good with minor comment.
test/jdk/tools/jpackage/helpers/jdk/jpackage/test/ApplicationLayout.java line
32:
> 30: public record ApplicationLayout(Path launchersDirectory, Path
> appDirectory,
> 31: Path runtimeDirectory, Path runtimeHomeDirectory, Path
> appModsDirectory,
> 32: Path destktopIntegrationDirectory, Path contentDirectory, Path
> libapplauncher) {
`destktop` -> `desktop`
-------------
PR Review: https://git.openjdk.org/jdk/pull/25051#pullrequestreview-2816721573
PR Review Comment: https://git.openjdk.org/jdk/pull/25051#discussion_r2074650278
