On Mon, 5 May 2025 17:29:33 GMT, Raffaello Giulietti <[email protected]>
wrote:
>> A fix to throw `OutOfMemoryError`, as done in releases ≤ 23.
>
> Raffaello Giulietti has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Increased min heap size to 8G.
LGTM
src/java.base/share/classes/java/lang/StringConcatHelper.java line 435:
> 433: static String doConcat(String s1, String s2) {
> 434: byte coder = (byte) (s1.coder() | s2.coder());
> 435: int newLength = checkOverflow(s1.length() + s2.length()) <<
> coder;
Might be mildly inefficient for this case since `checkOverflow` is designed for
the compound length+coder `long`. Since this is only used in the simple path it
should be easy for JITs to optimize, though.
-------------
Marked as reviewed by redestad (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/25038#pullrequestreview-2817218650
PR Review Comment: https://git.openjdk.org/jdk/pull/25038#discussion_r2074907577
