On Fri, 9 May 2025 20:43:46 GMT, Chen Liang <[email protected]> wrote:
>> Vicente Romero has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> fixing bugs, removing dead code
>
> make/langtools/src/classes/build/tools/symbolgenerator/CreateSymbols.java
> line 2216:
>
>> 2214: }
>> 2215: case ModuleMainClassAttribute a ->
>> ((ModuleHeaderDescription) feature).moduleMainClass =
>> a.mainClass().asInternalName();
>> 2216: case RuntimeVisibleTypeAnnotationsAttribute a -> {/* do
>> nothing for now */}
>
> I think this will make createsymbol created older reference/weakhashmap APIs'
> type parameter for older releases always have this annotation; but this
> should be fine. We can fix this for 26. The question is that now their type
> parameter and the actual parameter uses will see some inconsistent values for
> releases < 25 in the future.
Jan is taking a look at the changes for CreateSymbols. The change included in
this PR is the minimum for the build to pass, I will double check with him if
what he is doing will be pushed in a separate PR or as part of this PR, not
sure yet. Time is tight and we want this in 25 this is why I decided to move on
with this PR even though the CreateSymbols code complete. I forgot to mention
this before, sorry
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24746#discussion_r2082482663
