On Mon, 12 May 2025 09:16:30 GMT, Maurizio Cimadamore <[email protected]>
wrote:
>> While the compiler does not allow invalid queries to flow into
>> `SwitchBootstraps:typeSwitch`, a library user could do that and `typeSwitch`
>> does not prevent such usage pattern errors resulting in erroneous evaluation.
>>
>> For example this is not valid Java (and protected) by javac:
>>
>>
>> byte b = 1;
>> switch (b) {
>> case String s -> System.out.println("How did we get here? byte is " +
>> s.getClass());
>> }
>>
>>
>> but this is a valid call (and not protected):
>>
>>
>> CallSite shortSwitch = SwitchBootstraps.typeSwitch(
>> MethodHandles.lookup(),
>> "",
>> MethodType.methodType(int.class, short.class, int.class), // models
>> (short, int) -> int
>> String.class);
>>
>>
>> The `SwitchBootstraps.typeSwitch` returns wrong result since the code was
>> reasoning erroneously that this pair was unconditionally exact.
>>
>> This PR proposes to add the safety check in unconditional exactness which
>> will return false in erroneous pairs and then the actual check will be
>> delegated to `instanceof`. For the case of erroneous pairs with primitive
>> `boolean`s there is a check in the beginning of the type switch skeleton.
>
> src/java.base/share/classes/java/lang/runtime/SwitchBootstraps.java line 725:
>
>> 723:
>> 724: private static boolean isNotValidPair(Class<?> selectorType, Object
>> caseLabel) {
>> 725: return (selectorType == boolean.class && caseLabel !=
>> boolean.class && caseLabel != Boolean.class) ||
>
> What happens if `caseLabel` is a reference class? E.g. a `boolean` selector
> is incompatible with `String`.
`(selectorType == boolean.class && caseLabel != boolean.class && caseLabel !=
Boolean.class)` -> true so it is not a valid pair. Do you think it is wrong?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25090#discussion_r2086329296
