On Tue, 13 May 2025 13:28:27 GMT, Chen Liang <li...@openjdk.org> wrote:

>> src/java.base/share/classes/java/lang/ClassValue.java line 99:
>> 
>>> 97:      * that computed the value to associate.  A new invocation to {@code
>>> 98:      * computeValue}, which that {@code remove} call happens-before, 
>>> happens to
>>> 99:      * re-establish this happens-before relationship.</li>
>> 
>> Suggestion:
>> 
>>      * computeValue}, which that {@code remove} call happens-before,
>>      * re-establishes this happens-before relationship.</li>
>
> I think `can re-establish` or `will re-establish` is better just because this 
> happens after the outcome. What do you think?

`will re-establish the happens-before relationship` sounds good

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24043#discussion_r2086880480

Reply via email to