On Thu, 8 May 2025 18:07:42 GMT, Justin Lu <j...@openjdk.org> wrote: >> Please review this PR which clarifies the behavior for integer and fraction >> limits in NumberFormat and implementing classes. An associated CSR is filed. >> >> There have been a few bugs submitted which indicate a misconception that >> these limits impact parsing. The actual behavior is that these limits only >> affect formatting. The specification is vague regarding this, and can be >> explicitly updated to eliminate confusion. As the implementing classes are >> updated to use `inheritDoc`, some shuffling around in the method specs are >> included in this change as well. >> >> Alternatively I considered making this change as implementation specific to >> DecimalFormat and CompactNumberFormat only. (i.e. leave flexibility for >> other NumberFormat subclasses to define their own behavior on whether the >> limits affect parsing.) I am open to this option as well, but initially >> decided against it as >> 1) Unlike formatting, it seems like a rare use case that you would want to >> suppress the range of digits of accepted during parsing. >> `setParseIntegerOnly()` already provides functionality to toggle between >> integer and fraction parsing. >> 2) The limits affecting formatting only has been the long-standing behavior >> for all the subclasses of NumberFormat provided by the OpenJDK reference >> implementation. > > Justin Lu has updated the pull request with a new target base due to a merge > or a rebase. The incremental webrev excludes the unrelated changes brought in > by the merge/rebase. The pull request contains five additional commits since > the last revision: > > - CSR review - directed inheritDoc; make 'concrete subclass' wording > normative > - Merge branch 'master' into JDK-8352755-limit-clarifications > - Merge branch 'master' into JDK-8352755-limit-clarifications > - Naoto's review: apiN -> implN. Rewording of maxintdig callout > - init
Marked as reviewed by naoto (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk/pull/24265#pullrequestreview-2837519548
