On Wed, 7 May 2025 17:41:07 GMT, Lance Andersen <lan...@openjdk.org> wrote:
>> Henry Jen has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Restore Validator access level > > test/jdk/tools/jar/ValidatorTest.java line 145: > >> 143: var template = out.toByteArray(); >> 144: // ISO_8859_1 to keep the 8-bit value >> 145: var s = new String(template, StandardCharsets.ISO_8859_1); > > Ok, but the zip is being created using UTF_8.... UTF-8 messed up the index, we don't want any conversion to happen. Warning: Entry META-INFMAANIFEST.MF in local file header is not in central directory Warning: Entry META-INF/BANIFEST.MF in local file header is not in central directory Warning: Entry METAMINF/AANIFEST.MF in central directory is not in local file header Warning: Entry METAMINF/BANIFEST.MF in central directory is not in local file header ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/24430#discussion_r2089340789
