On Wed, 7 May 2025 18:00:23 GMT, Henry Jen <henry...@openjdk.org> wrote:
>> src/jdk.jartool/share/classes/sun/tools/jar/Validator.java line 127:
>>
>>> 125:
>>> 126: public DedupEntryNames(boolean isCEN) {
>>> 127: this.isCEN = isCEN;
>>
>> Might be clearer if this was an enum vs boolean?
>
> I feel the same way but wondering if that's an overkill.
Refactored to consolidate validation on entries into a standalone
EntryValidator. Hope that's easier to understand.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24430#discussion_r2092018706
